Date: Sat, 29 Jun 2013 19:19:14 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Tim Kientzle <kientzle@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r252376 - head/lib/libutil Message-ID: <20130629161914.GD91021@kib.kiev.ua> In-Reply-To: <201306291552.r5TFqnLV022460@svn.freebsd.org> References: <201306291552.r5TFqnLV022460@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--1l9qxdz78y/2tmkl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 29, 2013 at 03:52:49PM +0000, Tim Kientzle wrote: > Author: kientzle > Date: Sat Jun 29 15:52:48 2013 > New Revision: 252376 > URL: http://svnweb.freebsd.org/changeset/base/252376 >=20 > Log: > Fix -Wunsequenced warning What is this ? From the name of the warning, it sounds as if the problem is in the lack of sequence point between two modifications of the same variable in the expression ? But, there function' argument evaluation and function call are separated by seq point, AFAIR. Could you, please, clarify ? [Not that I think that the changes are bad] > =20 > Submitted by: dt71@gmx.com >=20 > Modified: > head/lib/libutil/login_times.c >=20 > Modified: head/lib/libutil/login_times.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/lib/libutil/login_times.c Sat Jun 29 15:51:27 2013 (r252375) > +++ head/lib/libutil/login_times.c Sat Jun 29 15:52:48 2013 (r252376) > @@ -96,7 +96,7 @@ parse_lt(const char *str) > else > m.lt_start =3D 0; > if (*p =3D=3D '-') > - p =3D parse_time(++p, &m.lt_end); > + p =3D parse_time(p + 1, &m.lt_end); > else > m.lt_end =3D 1440; > =20 --1l9qxdz78y/2tmkl Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iQIcBAEBAgAGBQJRzwkBAAoJEJDCuSvBvK1BQ14P/12Cu91+LHgAxc5bH9AiB6XW XqWqH630D+2ok9YxJs3dd7bqNEskM+BxC4PpQpQHn8It5MP1w5IfBWGxkhBZkQC0 uhQfmgQ6w8BZUMd0qFNg0Yx1lvyM2k1bjDuvEh2a7irLkKsgtRSIKSLsBBJu7yjC Q8XuBAjiAxIoTNCLL4T6G7iJb4ST3WnQ7DyGbNvxClDGPC3JMXGK41kt5QemcHio FfVRr+wbn22ipjuDuTLM8sA40QHGeN1XM6EkafcDT/3P8yNWlhKhBpIr5u76erz4 cTn6Q0EjThbLUO/6+F6rwFisgXbF0w9CTtFYm1ZF0nEAR4jWeXTejmllPX21I9u+ z6pu++oW/c9U25EKu+aPtvmwwSAbH8ZNROlJzXewFLr8zMbYoXERnJYP4alvqcOj 3kAsOzhHVt9rfn53VIl9kuXABGhhQ2U+q7eCYffiZp9ukM7L7AKPCNaLtAzS/22q ROR7Lq62DwqEgk4iQUHLu0pjY4qBc8iXxTSF6pEpcQzMwsBw+dd3U8Bsg5LWD+Eh RKpD+skjMRqzrnc3kGqWRdSgNVaJIt4M8gR2WwyYwTZKfhMi+3I4U1LG5QeW64nN s6V+B8s9jF9ZQXupzTyqjxg6zBP5lRYjPQBP4YDFRMK9KXcfNvPOSeCeVDHD4sP3 f8DnNyXSC7DNYzWwpOxJ =lPA8 -----END PGP SIGNATURE----- --1l9qxdz78y/2tmkl--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130629161914.GD91021>