Date: Fri, 22 May 2015 11:47:12 -0700 From: Oleksandr Tymoshenko <gonzo@freebsd.org> To: Andrew Turner <andrew@fubar.geek.nz> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r283275 - head/sys/dev/fdt Message-ID: <9A12B406-AD79-4DBE-B91E-0C9CB3596E40@freebsd.org> In-Reply-To: <20150522115315.5e2ba6fa@bender> References: <201505220200.t4M20jfi082771@svn.freebsd.org> <20150522115315.5e2ba6fa@bender>
next in thread | previous in thread | raw e-mail | index | archive | help
> On May 22, 2015, at 3:53 AM, Andrew Turner <andrew@fubar.geek.nz> wrote: > > On Fri, 22 May 2015 02:00:45 +0000 (UTC) > Oleksandr Tymoshenko <gonzo@FreeBSD.org> wrote: > >> Author: gonzo >> Date: Fri May 22 02:00:44 2015 >> New Revision: 283275 >> URL: https://svnweb.freebsd.org/changeset/base/283275 >> >> Log: >> Add helper method fdt_find_child to make access to child nodes >> easier. >> Some FDT nodes have complex properties organized as a child >> sub-nodes (e.g. timing for LCD panel) we need easy way to obtain >> handles for these sub-nodes > > Why is this named fdt_find_child? It's not fdt specific so should be > named something like ofw_bus_find_child and live in > sys/dev/ofw/ofw_bus_subr.c. > > In general we are trying to move away from the fdt_ functions unless > absolutely needed. I wasn't aware of this. Thanks for pointing out, will change name later today or tomorrow.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9A12B406-AD79-4DBE-B91E-0C9CB3596E40>