Date: Sat, 29 Mar 2008 11:52:55 +0000 From: "Bruce M. Simpson" <bms@FreeBSD.org> To: swp@uni-altai.ru Cc: freebsd-ports-bugs@FreeBSD.org, linimon@FreeBSD.org Subject: Re: ports/122223: [patch] net/mrouted do not see all network interfaces for me Message-ID: <47EE2D97.8020404@FreeBSD.org> In-Reply-To: <200803290657.m2T6v3tF005906@freefall.freebsd.org> References: <200803290657.m2T6v3tF005906@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, Thanks for the patch. linimon@FreeBSD.org wrote: > Old Synopsis: mrouted do not see all network interfaces for me > New Synopsis: [patch] net/mrouted do not see all network interfaces for me > > Responsible-Changed-From-To: freebsd-ports-bugs->bms > Responsible-Changed-By: linimon > Responsible-Changed-When: Sat Mar 29 06:56:15 UTC 2008 > Responsible-Changed-Why: > Fix up synopsis and assign. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=122223 > I'm a bit concerned that it uses sbrk() as that is a very old function, and it has been deprecated in FreeBSD in favour of the mmap based memory allocator. Also it would be better if the code in question were rewritten to use getifaddrs(), as that does most of the legwork involved in getting interface information. Thanks BMS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47EE2D97.8020404>