Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 04 Feb 2014 20:08:50 +0000
From:      Max Brazhnikov <makc@freebsd.org>
To:        Mathieu Arnold <mat@freebsd.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r342510 - head/games/cutemaze
Message-ID:  <7443970.95gMSVNHBu@mercury.ph.man.ac.uk>
In-Reply-To: <36D80F89A7D5FF449E4FCBDF@ogg.in.absolight.net>
References:  <201402041149.s14BnPX0031911@svn.freebsd.org> <3033718.ko1yqU3EN4@mercury.ph.man.ac.uk> <36D80F89A7D5FF449E4FCBDF@ogg.in.absolight.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 04 Feb 2014 17:31:39 +0100 Mathieu Arnold wrote:
> +--On 4 f=C3=A9vrier 2014 14:36:38 +0000 Max Brazhnikov <makc@freebsd=
.org>
> wrote:
> | On Tue, 04 Feb 2014 14:37:07 +0100 Mathieu Arnold wrote:
> |> +--On 4 f=C3=A9vrier 2014 13:05:39 +0000 Max Brazhnikov <makc@free=
bsd.org>
> |> wrote:
> |> |=20
> |> | This part should be reverted.
> |> | Folks, please *review* what makeplist generates and don't commit=
 it
> |> | blindly.
> |>=20
> |> I for one would love to have feedback on what the evolved makeplis=
t
> |> should do better :-)
> |=20
> | It's way too aggressive for PLIST_SUB and this leads to false
> | substitutions  sometimes. bsd.qt.mk defines a number of QT_*DIR, bu=
t not
> | all of them should  be used (actually it depends on particular port=
).
> | We could help makeplist by telling explicitly which substitutions a=
re
> | right, e.g. by specifying OPTIONS_SUB.
>=20
> Most substitutions are right, I mean, in a perl port, I want PERL_VER=
, and
> SITE_PERL, and PERL5_MAN3, and... there are a few like QT_BINDIR whic=
h
> shouldn't go in it, but it feels more like having a blacklist than a
> whitelist.

Blacklist can be longer than whitelist :).

> Patch welcomes.

I'll think about it. The problem is not specific to Qt ports. I've alre=
ady been
beaten when KDE4_VERSION was improperly used for library version (just
coincidence). In fact, QT_BINDIR could be easily hidden for other ports=
,
but I'd like to see general solution.

Max



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7443970.95gMSVNHBu>