Date: Tue, 28 Feb 2006 00:19:36 -0500 (EST) From: Daniel Eischen <deischen@freebsd.org> To: Hajimu UMEMOTO <ume@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/net res_comp.c res_debug.c res_send.c Message-ID: <Pine.GSO.4.43.0602280003220.21022-100000@sea.ntplx.net> In-Reply-To: <yge7j7g8cgw.wl%ume@mahoroba.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 28 Feb 2006, Hajimu UMEMOTO wrote:
> Hi,
>
> >>>>> On Mon, 27 Feb 2006 22:08:16 +0000 (UTC)
> >>>>> Daniel Eischen <deischen@FreeBSD.org> said:
>
> deischen> Remove two functions that are not referenced in libc nor
> deischen> anywhere else I can find, not visible in <resolv.h> and
> deischen> which are also local in Solaris libresolv.
>
> I suspect this change. "They are not referenced in libc nor anywhere
> else in our tree" doesn't mean they can be removed, IMHO. Perhaps, it
> was backward compatibility thing and obsoleted. But, we lost certain
> functionality as they set some flags. It seems that BIND9 still has
> res_send_setqhook() and res_send_setrhook().
Well, they're not exported in Solaris 9 either. In our contrib'd
bind, they exist but are not referenced by anything within that
tree. Bind9 also redefines them to be __res_send_set{qr}hook(),
which we do not do. So even if something were expecting to find
them, it would have been looking for __res_send_setfoo() which
do not exist (even before my changes).
--
DE
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.GSO.4.43.0602280003220.21022-100000>