Date: Fri, 17 Jun 2011 11:41:03 +0400 (MSD) From: Dmitry Marakasov <amdmi3@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/157936: [bsd.port.mk] add LDFLAGS support Message-ID: <20110617074103.F0DA3B823@hades.panopticon> Resent-Message-ID: <201106170750.p5H7o5jc073878@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 157936 >Category: ports >Synopsis: [bsd.port.mk] add LDFLAGS support >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Jun 17 07:50:05 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Dmitry Marakasov >Release: FreeBSD 8.2-RELEASE i386 >Organization: >Environment: System: FreeBSD hades.panopticon 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Tue Mar 8 09:48:52 MSK 2011 root@hades.panopticon:/async/obj/usr/src/sys/HADES i386 >Description: Not long ago, CPPFLAGS support was added to bsd.port.mk. Strange thing, though, is that LDFLAGS support was not added along with it, as these two options are usually used/changed together. Handling them both will make it possible to remove CONFIGURE_ENV= lines from many ports, which is good as those are error-prone hacks (common mistage is CONFIGURE_ENV=LDFLAGS+=...), and will also allow more flexibility, which we may need soon as new LTO-capable compilers may require certain linker-only options and an ability for the user and/or ports system to change them. >How-To-Repeat: >Fix: --- bsd.port.mk.patch begins here --- Index: bsd.port.mk =================================================================== RCS file: /home/amdmi3/projects/freebsd/FreeBSD.cvs/ports/Mk/bsd.port.mk,v retrieving revision 1.684 diff -u -r1.684 bsd.port.mk --- bsd.port.mk 6 Jun 2011 05:53:51 -0000 1.684 +++ bsd.port.mk 17 Jun 2011 07:29:45 -0000 @@ -2277,6 +2277,7 @@ MOTIFLIB="${MOTIFLIB}" LIBDIR="${LIBDIR}" \ CC="${CC}" CFLAGS="${CFLAGS}" \ CPP="${CPP}" CPPFLAGS="${CPPFLAGS}" \ + LDFLAGS="${LDFLAGS}" \ CXX="${CXX}" CXXFLAGS="${CXXFLAGS}" \ MANPREFIX="${MANPREFIX}" @@ -3779,6 +3780,7 @@ ${SET_LATE_CONFIGURE_ARGS} \ if ! ${SETENV} CC="${CC}" CPP="${CPP}" CXX="${CXX}" \ CFLAGS="${CFLAGS}" CPPFLAGS="${CPPFLAGS}" CXXFLAGS="${CXXFLAGS}" \ + LDFLAGS="${LDFLAGS}" \ INSTALL="/usr/bin/install -c ${_BINOWNGRP}" \ INSTALL_DATA="${INSTALL_DATA}" \ INSTALL_LIB="${INSTALL_LIB}" \ --- bsd.port.mk.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110617074103.F0DA3B823>