Date: Wed, 02 Sep 2009 11:36:15 -0400 From: Ken Smith <kensmith@cse.Buffalo.EDU> To: Doug Barton <dougb@FreeBSD.org> Cc: remko@elvandar.org, svn-src-stable@FreeBSD.org, svn-src-all@FreeBSD.org, Alfred Perlstein <alfred@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-stable-8@FreeBSD.org Subject: Re: svn commit: r196746 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/usb dev/usb/input dev/xen/xenpci Message-ID: <1251905775.24711.32.camel@bauer.cse.buffalo.edu> In-Reply-To: <4A9E8BBE.9060000@FreeBSD.org> References: <200909020212.n822C7Il078379@svn.freebsd.org> <8497dc1520e5fe6b2b3727d5fb92f358.squirrel@www.jr-hosting.nl> <4A9E8BBE.9060000@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-oEGsUu8QJtWkVXcXRaIs
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
On Wed, 2009-09-02 at 08:14 -0700, Doug Barton wrote:
> That said, for RELENG_8 commits during the freeze re@ did ask in one
> of their many messages about commit approvals to paste the complete
> commit message in the MFC. So, bad Alfred, no cookie. :)
Just for clarification... We ask that you send your complete *proposed
commit message* in your *approval request*. We didn't say that your
commit message needs to include all of the text from the commit to head.
So, bad Doug, no cookie. :-)
FWIW my preference is, as usual, somewhere in between the two extremes.
Duplicating a lengthy commit message in a merge is overkill but in those
cases a short (one sentence max) summary of what changed being in the
merge commit message is helpful. For example when looking through the
commits for release notes fodder it can help. It also helps people who
take the peer review of commits being done seriously to get the warm
fuzzy feeling that the merge wasn't an accidental mis-merge (by seeing
that the code seems to match the brief description).
--=20
Ken Smith
- From there to here, from here to | kensmith@cse.buffalo.edu
there, funny things are everywhere. |
- Theodore Geisel |
--=-oEGsUu8QJtWkVXcXRaIs
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)
iEYEABECAAYFAkqekOQACgkQ/G14VSmup/YWfQCfSnHu68c34PDsv+MGUw5LCkvs
aAcAn3qSX4C2+6izZMbGIwsmKfvVZkRq
=kamy
-----END PGP SIGNATURE-----
--=-oEGsUu8QJtWkVXcXRaIs--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1251905775.24711.32.camel>