Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 04 Sep 2007 23:15:44 -0600 (MDT)
From:      "M. Warner Losh" <imp@bsdimp.com>
To:        hselasky@c2i.net
Cc:        perforce@freebsd.org, delphij@freebsd.org
Subject:   Re: PERFORCE change 126033 for review
Message-ID:  <20070904.231544.420517167.imp@bsdimp.com>
In-Reply-To: <200709041121.45990.hselasky@c2i.net>
References:  <200709040755.l847tPbn003371@repoman.freebsd.org> <200709041121.45990.hselasky@c2i.net>

next in thread | previous in thread | raw e-mail | index | archive | help
In message: <200709041121.45990.hselasky@c2i.net>
            Hans Petter Selasky <hselasky@c2i.net> writes:
: Hi,
: 
: In my opinion you should keep braces around single line if's .
: 
: if (xxx) {
:    yyy;
: }
: 
: This will reduce the chance of error next time you add a statement to an if.

Sadly, or joyfully depending on your viewpoint, style(9) says you must
remove them.  Since we follow style(9) in this project it is better to
be uniform than to get the tiny bit of safety adding them gives.

Warner



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070904.231544.420517167.imp>