Date: Thu, 06 Jun 2013 23:28:05 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: gjb@FreeBSD.org Cc: wblock@wonkity.com, svn-doc-head@FreeBSD.org, svn-doc-all@FreeBSD.org, doc-committers@FreeBSD.org Subject: Re: svn commit: r41848 - head/en_US.ISO8859-1/htdocs/layout/js Message-ID: <20130606.232805.1823224325157138890.hrs@allbsd.org> In-Reply-To: <20130606140542.GA1625@glenbarber.us> References: <201306061149.r56BnrNn023865@svn.freebsd.org> <alpine.BSF.2.00.1306060748550.64531@wonkity.com> <20130606140542.GA1625@glenbarber.us>
next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart(Thu_Jun__6_23_28_05_2013_413)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Glen Barber <gjb@FreeBSD.org> wrote in <20130606140542.GA1625@glenbarber.us>: gj> On Thu, Jun 06, 2013 at 07:59:17AM -0600, Warren Block wrote: gj> > On Thu, 6 Jun 2013, Glen Barber wrote: gj> > gj> > >Author: gjb gj> > >Date: Thu Jun 6 11:49:53 2013 gj> > >New Revision: 41848 gj> > >URL: http://svnweb.freebsd.org/changeset/doc/41848 gj> > > gj> > >Log: gj> > > Check for boolean 'true' case of w.n.dNT. gj> > > gj> > > Submitted by: des gj> > > Approved by: doceng (implicit) gj> > > gj> > >Modified: gj> > > head/en_US.ISO8859-1/htdocs/layout/js/google.js gj> > > gj> > >Modified: head/en_US.ISO8859-1/htdocs/layout/js/google.js gj> > >============================================================================== gj> > >--- head/en_US.ISO8859-1/htdocs/layout/js/google.js Thu Jun 6 08:05:17 2013 (r41847) gj> > >+++ head/en_US.ISO8859-1/htdocs/layout/js/google.js Thu Jun 6 11:49:53 2013 (r41848) gj> > >@@ -18,7 +18,7 @@ var h = document.location.host; gj> > > */ gj> > >var fbsdregex = /((docs|security|svnweb|wiki|www)\.freebsd\.org|google\.com)/i; gj> > > gj> > >-if (window.navigator.doNotTrack === "yes") { gj> > >+if (window.navigator.doNotTrack == true) { gj> > > allow_track = false; gj> > >} gj> > gj> > Could that just be gj> > gj> > if (window.navigator.doNotTrack) { gj> > allow_track = false; gj> > } gj> gj> Not as far as I can tell. If DNT is not set, gj> window.navigator.doNotTrack is null, so it would evaluate to: gj> gj> if () { gj> allow_track = false; gj> } gj> gj> which I believe will always evaluate true. null, "", and undefined are evaluated as false in Javascript. -- Hiroki ----Security_Multipart(Thu_Jun__6_23_28_05_2013_413)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (FreeBSD) iEYEABECAAYFAlGwnHUACgkQTyzT2CeTzy2etgCeJlHNwVqQpKqXgkICpM6n6VEM p7AAoLVv/Y0qSQALFbprBAdpEVxdc9yz =XrUR -----END PGP SIGNATURE----- ----Security_Multipart(Thu_Jun__6_23_28_05_2013_413)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130606.232805.1823224325157138890.hrs>