Date: Fri, 17 Dec 2004 17:12:24 -0500 From: Adam Weinberger <adamw@magnesium.net> To: pav@FreeBSD.org Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/irc/insub pkg-plist Message-ID: <41C359C8.6090708@magnesium.net> In-Reply-To: <1103294201.98746.33.camel@pav.hide.vol.cz> References: <200412161851.iBGIpEeq058112@repoman.freebsd.org> <1103275349.98746.10.camel@pav.hide.vol.cz> <20041217141852.GJ79222@elvis.mu.org> <1103294201.98746.33.camel@pav.hide.vol.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
Pav Lucistnik wrote: > Alfred Perlstein píše v pá 17. 12. 2004 v 06:18 -0800: > >>* Pav Lucistnik <pav@FreeBSD.org> [041217 01:22] wrote: >> >>>Alfred Perlstein p??e v ?t 16. 12. 2004 v 18:51 +0000: >>> >>>>alfred 2004-12-16 18:51:14 UTC >>>> >>>> FreeBSD ports repository >>>> >>>> Modified files: >>>> irc/insub pkg-plist >>>> Log: >>>> /usr/local/share/cows is usually not empty because a prerequesite of >>>> this port installs file in there. So replace the @dirrm with >>>> "@unexec rmdir %D/share/cows 2>/dev/null || true" as other ports >>>> do. I don't like this, but I don't know what else would work, >>>> it would be nice if this "feature" was implemented as a builtin >>>> to the package system. >>> >>>Is this software supposed to have the original cowsay files (those >>>provided by cowsay port) installed at the runtime? >>> >>>If yes, then you should add cowsay to RUN_DEPENDS and then you could >>>remove handling of share/cows directory from plist completely, because >>>cowsay port (dependency) would handle it. >> >>Yes, but it installs its own cows... >> is that ok? > > > Well, depends. I guess cows from the other package are not doing any > harm? Cowsay needs to be part of the RUN_DEPENDS anyway. Otherwise, you have a bunch of cow files around with nothing that can use them. Besides, cowsay isn't actually part of the build, anyway. Furthermore, the @unexec rm %D/share/cows 2>/dev/null|| true should be added to cowsay's pkg-plist, not insub's. # Adam -- Adam Weinberger adamw@magnesium.net || adamw@FreeBSD.org adamw@vectors.cx || adamw@gnome.org http://www.vectors.cx
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41C359C8.6090708>