Date: Sat, 6 Jul 2013 18:54:13 GMT From: Kevin Zheng <kevinz5000@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/180352: [maintainer-update] Trim/cleanup/convert for games/netrek-client-cow Message-ID: <201307061854.r66IsDJY040373@oldred.freebsd.org> Resent-Message-ID: <201307061900.r66J00Ot056973@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 180352
>Category: ports
>Synopsis: [maintainer-update] Trim/cleanup/convert for games/netrek-client-cow
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: maintainer-update
>Submitter-Id: current-users
>Arrival-Date: Sat Jul 06 19:00:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Kevin Zheng
>Release: 9.1-RELEASE-p4
>Organization:
>Environment:
FreeBSD sigma.local 9.1-RELEASE-p4 FreeBSD 9.1-RELEASE-p4 #0: Mon Jun 17 11:38:17 UTC 2013 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC i386
>Description:
Do some cleanup work on my port. This entails:
- Trim the Makefile header
- Remove indefinite article
- Switch from USE_GMAKE to USES= gmake
- Correctly use ${PREFIX} for sound files
- Add patch in preparation for sound support that comes with port
I don't plan to bump PORTREVISION just yet; there are no functional changes as sound support doesn't come with the port anyways.
>How-To-Repeat:
>Fix:
Apply the attached patch.
Patch attached with submission follows:
diff -ruN /usr/ports/games/netrek-client-cow/Makefile ./Makefile
--- /usr/ports/games/netrek-client-cow/Makefile 2012-11-16 23:57:46.000000000 -0600
+++ ./Makefile 2013-07-06 13:41:26.000000000 -0500
@@ -1,9 +1,5 @@
-# New ports collection makefile for: netrek-client-cow
-# Date created: 20 April 2012
-# Whom: Kevin Zheng <kevinz5000@gmail.com>
-#
+# Created by: Kevin Zheng <kevinz5000@gmail.com>
# $FreeBSD: ports/games/netrek-client-cow/Makefile,v 1.4 2012/11/17 05:57:46 svnexp Exp $
-#
PORTNAME= netrek-client-cow
PORTVERSION= 3.3.1
@@ -13,13 +9,14 @@
http://quozl.us.netrek.org/netrek/
MAINTAINER= kevinz5000@gmail.com
-COMMENT= A multi-player battle simulation with a Star Trek theme
+COMMENT= Multi-player battle simulation with a Star Trek theme
LIB_DEPENDS= Imlib2:${PORTSDIR}/graphics/imlib2
GNU_CONFIGURE= yes
-USE_GMAKE= yes
+USES= gmake
USE_SDL= sdl mixer
+
CONFIGURE_ARGS+= NORSA='\#'
post-patch:
@@ -28,7 +25,11 @@
${REINPLACE_CMD} -e 's|inline void|void|' \
${WRKSRC}/local.[ch]
${REINPLACE_CMD} -e 's|/usr|${PREFIX}|' \
- ${WRKSRC}/x11sprite.c ${WRKSRC}/netrek-client-cow.desktop
+ ${WRKSRC}/netrek-client-cow.desktop \
+ ${WRKSRC}/sound.c \
+ ${WRKSRC}/x11sprite.c
+ ${REINPLACE_CMD} -e 's|8000, AUDIO_U8, 1|22050, AUDIO_U8, 2|' \
+ ${WRKSRC}/sound.c
${REINPLACE_CMD} -e 's|games|bin|' \
${WRKSRC}/netrek-client-cow.desktop
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201307061854.r66IsDJY040373>