Date: Tue, 24 May 2005 05:01:12 -0700 From: Max Okumoto <okumoto@ucsd.edu> To: Harti Brandt <harti@freebsd.org> Cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/usr.bin/make job.c job.h main.c Message-ID: <hfy8a44yuv.fsf@multivac.sdsc.edu> In-Reply-To: <20050524131354.S50725@beagle.kn.op.dlr.de> (Harti Brandt's message of "Tue, 24 May 2005 13:20:31 %2B0200 (CEST)") References: <200505240914.j4O9EkrC043155@repoman.freebsd.org> <4292FE79.70205@ucsd.edu> <20050524124930.F50725@beagle.kn.op.dlr.de> <hf8y246fof.fsf@multivac.sdsc.edu> <20050524131354.S50725@beagle.kn.op.dlr.de>
next in thread | previous in thread | raw e-mail | index | archive | help
Harti Brandt <hartmut.brandt@dlr.de> writes:
> On Tue, 24 May 2005, Max Okumoto wrote:
>
> MO>Harti Brandt <hartmut.brandt@dlr.de> writes:
> MO>[stuff deleted]
> MO>> MO>Harti,
> MO>> MO>
> MO>> MO>Please make sure to attribute patches to DragonFly when you take
> MO>> MO>things from their CVS. Most of the work is in this patch is yours
> MO>> MO>but there are some changes that appear like they came from the DragonFly
> MO>> MO>tree.
> MO>>
> MO>> Can you point me at what you think came from DragonFly? If you talk about
> MO>> the ArgArray stuff, then there is the correct attribution in that commit.
> MO>> The stuff here was fully done by me. I didn't have a look at DragonFly's
> MO>> make since I got the ArgArray stuff.
> MO>>
> MO>> harti
> MO>
> MO>My mistake, if you are not tracking my work any more.
> MO>It just looked like some minor changes were similar to
> MO>what I did.
>
> Well, as you see from the ArgArray stuff, I'm tracking this when I have
> time to do so. I was a little bit surprised to see you disappear :-/
Well, I got the impression that didn't want stuff from me. After
I asked you to revert a change that broke a 20+ patches that I had
pending to send to you. You ignored the request. And your response
was to point out that one of the earlier patches had a mistake.
After that, the commits you did later on had gratuious white space
changes, and a double semi colon. Shrug.
>
> I just had a look at the current DFly sources - there's nothing that
> resembles the work in that commit.
>
> NB: It looks like you don't set DEFSHELL anymore in the Makefile, but you
> still use it in job.c. (I still think that having reviews for something so
> sensible like make makes sense). This unsetenv("ENV") thing is probably a
> candidate for a new .SHELL attribute.
>
> harti
Thanks I will fix that.
Max
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?hfy8a44yuv.fsf>