Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 16 Nov 2001 18:16:18 -0600
From:      Alfred Perlstein <bright@mu.org>
To:        Peter Wemm <peter@wemm.org>
Cc:        Julian Elischer <julian@vicor-nb.com>, current@FreeBSD.ORG, net@FreeBSD.ORG, wollman@FreeBSD.ORG
Subject:   Re: re-entrancy and the IP stack.
Message-ID:  <20011116181618.A13393@elvis.mu.org>
In-Reply-To: <20011117000251.A13B93811@overcee.netplex.com.au>; from peter@wemm.org on Fri, Nov 16, 2001 at 04:02:51PM -0800
References:  <3BF5A5D5.3D408744@vicor-nb.com> <20011117000251.A13B93811@overcee.netplex.com.au>

next in thread | previous in thread | raw e-mail | index | archive | help
* Peter Wemm <peter@wemm.org> [011116 18:02] wrote:
> Julian Elischer wrote:
> [..]
> > What is needed is obviously a 'per packet' storage location
> > for those things, defined in a "per protocol family" manner.
> > 
> > Luigi has already tried this scheme by defining a 
> > dummynet specific mbuf type that can  be prepended to the 
> > front of packets. What I suggest is to extend this
> > to defining a MT_PROTOSTORAGE. (or similar) mbuf type
> > that generic networking code is educated to ignore,
> > and that protocols can use to pass packet-specific state
> > information from one place to another.
> 
> Uhh.. no thanks.  Whatever you do, do *NOT* abuse the mbuf system
> for this.  We went to a lot of trouble (well, Garrett specifically)
> to rid the stacks of this obscenity.  Do *NOT* generalize it and undo
> it.  MT_DUMMYNET must die, not be propagated elsewhere.
> 
> If you want to have some general storage mechnaism, do *not* use mbufs
> for it.

*cough*
kthread_setspecific()
*cough*
kthread_getspecific()
*cough*

or just fix the code to pass this around as an extra paramter.

-- 
-Alfred Perlstein [alfred@freebsd.org]
'Instead of asking why a piece of software is using "1970s technology,"
 start asking why software is ignoring 30 years of accumulated wisdom.'
                           http://www.morons.org/rants/gpl-harmful.php3

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011116181618.A13393>