Date: Mon, 22 Dec 2003 15:55:08 +0300 (MSK) From: Gleb Smirnoff <glebius@cell.sick.ru> To: FreeBSD-gnats-submit@FreeBSD.org Subject: kern/60503: small error in modules installation Message-ID: <200312221255.hBMCt8rU087993@cell.sick.ru> Resent-Message-ID: <200312221300.hBMD0ZYG083655@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 60503
>Category: kern
>Synopsis: small error in modules installation
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Dec 22 05:00:35 PST 2003
>Closed-Date:
>Last-Modified:
>Originator: Gleb Smirnoff
>Release: FreeBSD 4.9-PRERELEASE i386
>Organization:
Bestcom ISP
>Environment:
System: FreeBSD cell.sick.ru 4.9-PRERELEASE FreeBSD 4.9-PRERELEASE #0: Fri Sep 19 10:22:46 MSD 2003 root@fade.bestcom.ru:/usr/obj/usr/src/sys/NUCLEUS i386
>Description:
When ${KMODDIR}, usually /modules, does not exist modules installation
process does not fail, but all modules are written into file /modules,
overwriting each other.
>How-To-Repeat:
su-2.05b# rm -rf /modules
su-2.05b# cd /usr/src/sys/modules/if_gif
su-2.05b# make
...
su-2.05b# make install
install -o root -g wheel -m 555 if_gif.ko /modules
su-2.05b# file /modules
/modules: ELF 32-bit LSB shared object, Intel 80386, version 1 (FreeBSD), not stripped
make installkernel will write all modules into one file "/modules".
>Fix:
--- kmod.mk.orig Mon Dec 22 15:29:59 2003
+++ kmod.mk Mon Dec 22 15:43:49 2003
@@ -183,6 +183,9 @@
realinstall: _kmodinstall
.ORDER: beforeinstall _kmodinstall
_kmodinstall:
+.if !exists(${KMODDIR})
+ @mkdir -p ${KMODDIR};
+.endif
${INSTALL} -o ${KMODOWN} -g ${KMODGRP} -m ${KMODMODE} \
${_INSTALLFLAGS} ${PROG} ${DESTDIR}${KMODDIR}
.endif !target(realinstall)
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200312221255.hBMCt8rU087993>