Date: Thu, 22 Sep 2005 10:18:09 +0900 (JST) From: Noritoshi Demizu <demizu@dd.iij4u.or.jp> To: freebsd-net@freebsd.org Subject: Re: rfc2385 (tcp md5 checksums) in -current broken? Message-ID: <20050922.101809.45174516.Noritoshi@Demizu.ORG> In-Reply-To: <dgs53j$348$1@sea.gmane.org> References: <20050921.161113.59648691.Noritoshi@Demizu.ORG> <20050921.184114.115904070.Noritoshi@Demizu.ORG> <dgs53j$348$1@sea.gmane.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> > --- print-tcp.c-ORG Thu Apr 21 15:36:05 2005 > > +++ print-tcp.c Wed Sep 21 18:43:51 2005 > > @@ -799,7 +799,7 @@ > > MD5_Update(&ctx, tcpmd5secret, strlen(tcpmd5secret)); > > MD5_Final(sig, &ctx); > > > > - if (memcmp(rcvsig, sig, 16)) > > + if (memcmp(rcvsig, sig, TCP_SIGLEN) == 0) > > return (SIGNATURE_VALID); > > else > > return (SIGNATURE_INVALID); > > The original code there certainly looks wrong! After patching, FreeBSD's > checksum returns valid. I'll have to see what's up with the originating > checksum. Many Thanks! Thanks. I submitted this problem to the bug tracker of the tcpdump project at http://sourceforge.net/projects/tcpdump/ . The request ID is 1298259. Regards, Noritoshi Demizu
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050922.101809.45174516.Noritoshi>