Date: Thu, 7 Apr 2011 13:53:36 -0700 From: Garrett Cooper <yanegomi@gmail.com> To: Alexander Best <arundel@freebsd.org> Cc: freebsd-current@freebsd.org, freebsd-toolchain@freebsd.org Subject: Re: [RFC] adding -Wmissing-include-dirs to CWARNFLAGS Message-ID: <BANLkTinPqjG5EigkULVrXaK5pCAN%2Bjs00w@mail.gmail.com> In-Reply-To: <BANLkTinWdMf3jXa=zk4Yi08oW4Du4zzeFg@mail.gmail.com> References: <20110407185510.GA94830@freebsd.org> <BANLkTinWdMf3jXa=zk4Yi08oW4Du4zzeFg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 7, 2011 at 1:53 PM, Garrett Cooper <yanegomi@gmail.com> wrote: > On Thu, Apr 7, 2011 at 11:55 AM, Alexander Best <arundel@freebsd.org> wro= te: >> hi there, >> >> i'd like to propose adding -Wmissing-include-dirs to CWARNFLAGS. this wi= ll let >> tinderbox fail, if any new kernel code was committed with (a) broken inc= lude >> dir(s). >> >> i ran a test via >> >> make toolchains >> make MAKE_JUST_KERNELS=3Dyes tinderbox >> >> and nothing seemed to go wrong with the extra warning enabled. i even fo= und a >> missing include dir, which should be fixed by the attached patch. >> >> opinions? >> >> so far i've only tested this with gcc. i think someone on #freebsd-clang= told >> me that -Wmissing-include-dirs is a noop for clang (for whatever reasons= ). > > =A0 =A0make -f /etc/src.conf -VMODULES_OVERRIDE and make -f /etc/src.conf > -VMODULES_OVERRIDE say... (tinderbox should also really ignore these > files, but it doesn't currently)? Sorry. Second invocation should have been make.conf, not src.conf.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTinPqjG5EigkULVrXaK5pCAN%2Bjs00w>