Date: Wed, 24 Aug 2005 22:56:27 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/pkill pkill.1 pkill.c Message-ID: <20050824205627.GD755@garage.freebsd.pl> In-Reply-To: <200508241602.59424.jhb@FreeBSD.org> References: <200508241938.j7OJcSNW066686@repoman.freebsd.org> <200508241602.59424.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Xm/fll+QQv+hsKip Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 24, 2005 at 04:02:57PM -0400, John Baldwin wrote: +> On Wednesday 24 August 2005 03:38 pm, Pawel Jakub Dawidek wrote: +> > pjd 2005-08-24 19:38:28 UTC +> > +> > FreeBSD src repository +> > +> > Modified files: +> > usr.bin/pkill pkill.1 pkill.c +> > Log: +> > Modify '-F' option to work nicely with pidfile(3) - a pidfile given = as +> > an argument has to be locked. +> > +> > Revision Changes Path +> > 1.17 +8 -0 src/usr.bin/pkill/pkill.1 +> > 1.27 +14 -0 src/usr.bin/pkill/pkill.c +>=20 +> I guess the only thing that makes me uncomfortable about this change is = that=20 +> it means pkill won't work with 3rd party program's pid files since they = are=20 +> probably not using pidfile(3). Maybe have some way of turning off the f= lock=20 +> requirement? Some daemons, even if they don't use pidfile(3), they do use flock(2) to lo= ck the pidfile (eg. cron(8)). I added this option to pkill(1) in the past, but I wasn't very happy with it until today... On the other hand, I added it to avoid: kill `cat /var/run/daemon.pid`... Hmm, what do you think about reverting '-F' behaviour and make it use flock(2) only when '-L' is also given? --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --Xm/fll+QQv+hsKip Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFDDN77ForvXbEpPzQRAtCyAKCdQHYTPvQyIOvcq5aUCdNw3dw80gCfSRZf l6414wNVk9ZIZJm5hr26h8w= =xvNY -----END PGP SIGNATURE----- --Xm/fll+QQv+hsKip--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050824205627.GD755>