Date: Tue, 3 Feb 2004 19:29:18 +0200 From: Ruslan Ermilov <ru@freebsd.org> To: Dag-Erling Sm?rgrav <des@des.no> Cc: Ken Smith <kensmith@cse.Buffalo.EDU> Subject: Re: cvs commit: src/kerberos5/lib/libroken Makefile Message-ID: <20040203172918.GD82507@FreeBSD.org.ua> In-Reply-To: <xzpk7345bez.fsf@dwp.des.no> References: <200402030932.i139WBpQ054113@repoman.freebsd.org> <20040203112824.01dfdc99@localhost> <20040203163214.GD17960@electra.cse.Buffalo.EDU> <401FD252.7F56765E@freebsd.org> <xzpk7345bez.fsf@dwp.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
--BQPnanjtCNWHyqYD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Tue, Feb 03, 2004 at 06:18:44PM +0100, Dag-Erling Sm?rgrav wrote:
> Andre Oppermann <andre@freebsd.org> writes:
> > I'm not a perl hacker so I can't really comment on the code snipped
> > below but it looks strange that the first $ENV{} has the environment
> > variable name in "" and the second one in '' quotes.
>=20
> this has no significance.
>=20
> > # The username of the committer.
> > $COMMITTER =3D $ENV{"LOGNAME"} || $ENV{'USER'} || getlogin
> > || (getpwuid($<))[0] || sprintf("uid#%d",$<);
>=20
> This should be
>=20
> $COMMITTER =3D $ENV{'CVS_USER'} ||
> die("Not invoked by CVS!\n");
>=20
Isn't CVS_USER defined only in pserver?
Cheers,
--=20
Ruslan Ermilov
FreeBSD committer
ru@FreeBSD.org
--BQPnanjtCNWHyqYD
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQFAH9puUkv4P6juNwoRAqHsAJ9D9CGtD4M6NwQEHQDvuJO/lQ2/bwCeJ40m
muXGHIioNH+afEQaVTZ68g0=
=LN4Y
-----END PGP SIGNATURE-----
--BQPnanjtCNWHyqYD--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040203172918.GD82507>