Date: Wed, 29 Jan 2014 23:48:43 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Juergen Lock <nox@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r341790 - head/multimedia/szap-s2 Message-ID: <33CFB80361C43DC17B99E87C@atuin.in.mat.cc> In-Reply-To: <201401292244.s0TMib46086321@svn.freebsd.org> References: <201401292244.s0TMib46086321@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
+--On 29 janvier 2014 22:44:37 +0000 Juergen Lock <nox@FreeBSD.org> wrote:
| +
| +.include <bsd.port.options.mk>
|
| do-install:
| (cd ${WRKSRC} && ${INSTALL_PROGRAM} szap-s2 ${STAGEDIR}/${PREFIX}/bin)
| -.if !defined(NOPORTDOCS)
| - ${MKDIR} ${DOCSDIR}
| - (cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} ${DOCSDIR})
| +.if ${PORT_OPTIONS:MDOCS}
| + ${MKDIR} ${STAGEDIR}${DOCSDIR}
| + (cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} ${STAGEDIR}${DOCSDIR})
| .endif
Hi,
Could you remove the include of port.options and always install the DOCS
into the staging area ? It would save us parsing bsd.port.mk one time too
many.
Like it says on https://wiki.freebsd.org/ports/StageDir
The DOCS/EXAMPLES .if blocks can be made unconditional, except in cases
when installed files are big enough to cause significant I/O overhead.
Regards,
--
Mathieu Arnold
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?33CFB80361C43DC17B99E87C>