Date: Fri, 29 Jan 2010 07:38:40 -0600 From: Stephen Montgomery-Smith <stephen@missouri.edu> To: Ion-Mihai Tetcu <itetcu@FreeBSD.org> Cc: Charlie Kester <corky1951@comcast.net>, "freebsd-ports@freebsd.org" <freebsd-ports@FreeBSD.org> Subject: Re: patch upgrade for port committers? Message-ID: <4B62E4E0.6090006@missouri.edu> In-Reply-To: <20100129125203.1273ed4f@it.buh.tecnik93.com> References: <4B61E988.1000801@missouri.edu><4B620382.7070902@FreeBSD.org><20100128224601.GA64692@comcast.net><alpine.BSF.2.00.1001281700480.92484@cauchy.math.missouri.edu> <20100129125203.1273ed4f@it.buh.tecnik93.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Ion-Mihai Tetcu wrote: > On Thu, 28 Jan 2010 17:01:44 -0600 (CST) > Stephen Montgomery-Smith<stephen@missouri.edu> wrote: >> Also, I have taken to using shar files instead of diff's when >> creating new files. > > Don't please, it makes committer's work harder. > And update to a port should be a diff. Preferably a cvs diff -u. > > I am thinking of something like this: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/142360 I separated the diff and the shar files - diff for what is already existing, and shar for new files. Are you saying that you would prefer if I had done a single diff with "diff -urN"? Part of the reason I started to do this is because, even when I had clear messages like "there are new files XXX and YYY" they would still get forgotten by committers.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B62E4E0.6090006>