Date: Mon, 09 Nov 2009 13:37:22 +0200 From: Giorgos Keramidas <keramida@freebsd.org> To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= <des@des.no> Cc: freebsd-hackers@freebsd.org, Alexander Best <alexbestms@math.uni-muenster.de>, Gabor Kovesdan <gabor@freebsd.org> Subject: Re: [patch] burncd: honour for envar SPEED Message-ID: <87vdhkgc99.fsf@kobe.laptop> In-Reply-To: <86hbt4j9v8.fsf@ds4.des.no> ("Dag-Erling =?iso-8859-1?Q?Sm=F8?= =?iso-8859-1?Q?rgrav=22's?= message of "Mon, 09 Nov 2009 11:00:43 %2B0100") References: <permail-2009110901223680e26a0b000035b7-a_best01@message-id.uni-muenster.de> <87y6mg17y2.fsf@kobe.laptop> <86hbt4j9v8.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable On Mon, 09 Nov 2009 11:00:43 +0100, Dag-Erling Sm=F8rgrav <des@des.no> wrot= e: > Giorgos Keramidas <keramida@ceid.upatras.gr> writes: >> atoi() doesn't really have error checking and it does not necessarily >> affect `errno'. > > man 3 expand_number I know, but thanks. In this case, expand_number's logic for parsing possible SI suffixes is not useful and may be slightly confusing. I'm not sure what CDROM_SPEED=3D'4m' would mean for burncd's -s option, for example. > And please don't call it SPEED or WRITE_SPEED or anything generic; call > it BURNCD_SPEED or CDROM_BURN_SPEED or something unambiguous. The envar > used to specify the device is called CDROM, not DEVICE. Good point. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (FreeBSD) iEYEARECAAYFAkr3/vgACgkQ1g+UGjGGA7Y2+ACdFLfjx1Nm0icvPhGlwa107q+r O0gAn3ORD0ATJtV9gYZMQpVCk7onZEYl =g4qT -----END PGP SIGNATURE----- --=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?87vdhkgc99.fsf>