Date: Thu, 30 Jan 2014 09:00:09 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r341809 - head/games/fkiss Message-ID: <20140130090009.GA61586@FreeBSD.org> In-Reply-To: <21D89719A6E320FEE5CD2C6B@atuin.in.mat.cc> References: <201401300827.s0U8Rtav032343@svn.freebsd.org> <21D89719A6E320FEE5CD2C6B@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 30, 2014 at 09:56:58AM +0100, Mathieu Arnold wrote:
> +--On 30 janvier 2014 08:27:55 +0000 Alexey Dokuchaev <danfe@FreeBSD.org>
> wrote:
> | .include <bsd.port.pre.mk>
> |
> | -.if ${HAVE_GNOME:Mesound}!=""
> | +# XXX should be converted to OptionsNG
> | +.if ${HAVE_GNOME:Mesound}
> | +USES+= pkgconfig
>
> As changing USES *after* bsd.port.pre.mk isn't allowed (mainly because it
> has absolutely *no* effect, the USES being included before.) Yes, it should
> be converted.
True; I've added it there so whoever converts it later won't miss that it
calls pkg-config.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140130090009.GA61586>