Date: Thu, 22 Aug 2013 17:25:15 +0400 From: "Andrey V. Elsukov" <bu7cher@yandex.ru> To: Will Andrews <will@firepipe.net> Cc: freebsd-net@freebsd.org, "Justin T. Gibbs" <gibbs@freebsd.org>, Andre Oppermann <andre@freebsd.org>, Hiroki Sato <hrs@FreeBSD.org>, Alan Somers <asomers@freebsd.org> Subject: Re: CFR: FIB handling improvements Message-ID: <5216113B.3030601@yandex.ru> In-Reply-To: <CADBaqmi6c7v8ojry8uViRi9tK18n8_RaDrP%2BUjvcmEN9guWm3w@mail.gmail.com> References: <CADBaqmi6c7v8ojry8uViRi9tK18n8_RaDrP%2BUjvcmEN9guWm3w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------020400040407000003070406 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit 21.08.2013 19:42, Will Andrews wrote: > Hi, > > I'm working to port forward to FreeBSD/head, improvements made to FIB > handling by my colleagues Alan Somers and Justin Gibbs. > > Please review: http://people.freebsd.org/~will/fix-fib-issues.1.diff > > This patch includes fixes for several issues relating to FIBs: Hi, I also have a small patch. Since icmp6_mtudisc_update() calls tcp_maxmtu6() where inc->inc_fibnum is used, I think it is good idea to initialize this field. -- WBR, Andrey V. Elsukov --------------020400040407000003070406 Content-Type: text/plain; charset=UTF-8; name="icmp6.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="icmp6.diff" Index: head/sys/netinet6/icmp6.c =================================================================== --- head/sys/netinet6/icmp6.c (revision 254653) +++ head/sys/netinet6/icmp6.c (working copy) @@ -1227,6 +1227,7 @@ icmp6_mtudisc_update(struct ip6ctlparam *ip6cp, in mtu = IPV6_MMTU - 8; bzero(&inc, sizeof(inc)); + inc.inc_fibnum = M_GETFIB(m); inc.inc_flags |= INC_ISIPV6; inc.inc6_faddr = *dst; if (in6_setscope(&inc.inc6_faddr, m->m_pkthdr.rcvif, NULL)) --------------020400040407000003070406--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5216113B.3030601>