Date: Wed, 4 Feb 2004 20:37:35 +0200 From: Ruslan Ermilov <ru@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys sx.h Message-ID: <20040204183735.GK5546@FreeBSD.org.ua> In-Reply-To: <20040205042752.D3649@gamplex.bde.org> References: <200402041418.i14EIMfv054158@repoman.freebsd.org> <20040204163157.GC5546@FreeBSD.org.ua> <20040205042752.D3649@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--++alDQ2ROsODg1x+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 05, 2004 at 04:42:38AM +1100, Bruce Evans wrote: > On Wed, 4 Feb 2004, Ruslan Ermilov wrote: >=20 > > On Wed, Feb 04, 2004 at 06:18:21AM -0800, Bruce Evans wrote: > > > bde 2004/02/04 06:18:21 PST > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/sys sx.h > > > Log: > > > Include <sys/queue.h> before <sys/_lock.h> instead of depending on > > > namespace pollution in other headers. <sys/types.h> is now the only > > > prerequisite for <sys/sx.h>. > > > ... > > Please update the sx(9) manpage to reflect this change. >=20 > That's easy since the reflection is null :-). <sys/queue.h> isn't mentio= ned > in the man page. Folloing the man page gave it as a side effect of > including <sys/lock.h>. >=20 > The man page is not incorrect in requiring <sys/param.h> and <sys/lock.h> > before <sys/sx.h>. <sys/param.h> instead of <sys/types.h> is required > (for other headers) in practice, and <sys/lock.h> is required if > INVARIANTS is defined and sx_assert() is used. It's easier to document > <sys/lock.h> as a prerequisite than to document the ifdef tangle. >=20 Perhaps then, it would make sense to move <sys/lock.h> down, right after ``options INVARIANT*''? > <sys/mutex.h> enforces a prerequisite of <sys/lock.h> although it could > be unnecessary in similar cases. >=20 Why are we talking about <sys/mutex.h> now? ;) Cheers, --=20 Ruslan Ermilov FreeBSD committer ru@FreeBSD.org --++alDQ2ROsODg1x+ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAITvvUkv4P6juNwoRAqSAAJ4i0uyqV5saDb1cOstjEI4lhJY7rgCfV269 xoSzWk4TmJjEs30tondfDCk= =WKkm -----END PGP SIGNATURE----- --++alDQ2ROsODg1x+--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040204183735.GK5546>