Date: Tue, 17 Sep 2013 17:59:59 +0200 From: Olivier Smedts <olivier@gid0.org> To: "O. Hartmann" <ohartman@zedat.fu-berlin.de> Cc: Ivan Klymenko <fidaj@ukr.net>, FreeBSD CURRENT <freebsd-current@freebsd.org>, FreeBSD Ports <freebsd-ports@freebsd.org>, Ian Lepore <ian@freebsd.org> Subject: Re: CURRENT r255426: x11/nvidia-driver: nvidia_subr.c:835:46: error: too few arguments to function call, expected 10, have 9 (VM_PROT_READ | VM_PROT_WRITE), 0); Message-ID: <CABzXLYOva27jH-bNb3O_UY1c7WcrDT2crmHJSSAYejzFamaj4g@mail.gmail.com> In-Reply-To: <20130910010526.2a6aff37@thor.walstatt.dyndns.org> References: <20130909223748.61dd8859@thor.walstatt.dyndns.org> <20130910000237.6b5604da@nonamehost.local> <20130909231713.34ebfbdd@thor.walstatt.dyndns.org> <20130910002405.4aa701d0@nonamehost.local> <20130910004240.70bc281f@thor.walstatt.dyndns.org> <1378766963.1111.579.camel@revolution.hippie.lan> <20130910010526.2a6aff37@thor.walstatt.dyndns.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello,
2013/9/10 O. Hartmann <ohartman@zedat.fu-berlin.de>
> Yes, you're correct and my face is red like a tomatoe :-(
>
> I try this sed replacement expression:
> sed -i -e '/\&virtual_address\, size\, \
> VMFS_ANY\_SPACE\,$/s//\&virtual_address\, size\, 0\, \
> VMFS_ANY\_SPACE\,/g' work/NVIDIA-FreeBSD-x86_64-325.15/src/nvidia_subr.c
>
> It works from the command line, but it doesn't work from the (attached)
> Makefile-patch.
>
A little bit late here (I see a patch has been commited to
x11/nvidia-driver/Makefile, with a shorter sed expression) but your
problems seems to come from make interpreting "$".
The "$/" variable is null, it's stripped from the sed expression which
becomes invalid.
You should escape the "$" inside the sed expression by doubling it.
Cheers
--
Olivier Smedts _
ASCII ribbon campaign ( )
e-mail: olivier@gid0.org - against HTML email & vCards X
www: http://www.gid0.org - against proprietary attachments / \
"Il y a seulement 10 sortes de gens dans le monde :
ceux qui comprennent le binaire,
et ceux qui ne le comprennent pas."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CABzXLYOva27jH-bNb3O_UY1c7WcrDT2crmHJSSAYejzFamaj4g>