Date: Sun, 12 Dec 2004 17:13:26 -0800 From: Julian Elischer <julian@elischer.org> To: Julian Elischer <julian@elischer.org> Cc: Julian Elischer <julian@freebsd.org> Subject: Re: cvs commit: src/sys/sys mouse.h src/sys/dev/usb ums.c usbhid.h Message-ID: <41BCECB6.7010202@elischer.org> In-Reply-To: <41BCDEC1.4000009@elischer.org> References: <20041212133752.GE68019@tuatara.fishballoon.org> <200412121411.aa89799@salmon.maths.tcd.ie> <20041212142640.GF68019@tuatara.fishballoon.org> <41BCDEC1.4000009@elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Julian Elischer wrote: >>> As pointed out in the PR though, it doesn't seem necessary to change >>> struct mousestatus and the MOUSE_GETSTATUS ioctl API just to make >>> the device work. All other mouse drivers in the tree will need to >>> be updated to initialise the new `dt' field. There's also one part >>> of the patch that looks as if it could easily break other devices: >> >> >> >> Ahhh, my bad. I'd read the PR and thought it was the last version >> mentioned by marko@ (without the mousestatus change) that had been >> committed. Although now that I look a bit closer I can't actually find >> that version anywhere. >> >> I'll shut up now. >> >> Scott >> > > uh my bad.. I THOUGHT I had committed the last version, as I got it from > the URL he supplied as being the last one.. > I'll look around to see if there is a newer one, or try fix this one.. ok, so before I fix it.. all reference to sc->status.dt should go away right? meaning that nothing can use the extra axis...
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41BCECB6.7010202>