Date: Thu, 26 Apr 2001 14:26:46 -0700 (PDT) From: Matt Dillon <dillon@earth.backplane.com> To: "John W. De Boskey" <jwd@bsdwins.com> Cc: current@FreeBSD.ORG, Jeroen Ruigrok/Asmodai <asmodai@wxs.nl> Subject: Re: cp -u patch Message-ID: <200104262126.f3QLQkA56841@earth.backplane.com> References: <20010426222132.B55566@daemon.ninth-circle.org> <20010426171522.A51935@bsdwins.com>
next in thread | previous in thread | raw e-mail | index | archive | help
:You are one brave soul if the only precedent you have for this
:patch is GNU cp.
:
:Personally, I see nothing wrong with it.
The time check is broken, for one. Any adjustment to the system time
has the potential to screw up the feature. The time check must be
T1 != T2, not T1 < T2, and then use utimes() to set the destination file's
time to be the same as the original. And that's just one issue out of
many.
There is a whole lot more to doing an efficient copy then simply checking
the mtime. It's silly to try to integrate it into 'cp'. Use cpdup
instead. plug plug plug.
-Matt
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200104262126.f3QLQkA56841>