Date: Tue, 5 Mar 2013 20:15:38 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Jean-S?bastien P?dron <jean-sebastien.pedron@dumbbell.fr> Cc: freebsd-current@freebsd.org Subject: Re: r247835: drm2 code breaks buildkernel Message-ID: <20130305181538.GJ3794@kib.kiev.ua> In-Reply-To: <51362002.2060906@dumbbell.fr> References: <5135C70B.50906@zedat.fu-berlin.de> <5135CD0E.8040801@dumbbell.fr> <5135DE36.9010303@zedat.fu-berlin.de> <20130305123016.GE1483@glenbarber.us> <5135FD78.1050608@FreeBSD.org> <20130305153736.GH3794@kib.kiev.ua> <51362002.2060906@dumbbell.fr>
next in thread | previous in thread | raw e-mail | index | archive | help
--oplxJGu+Ee5xywIT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 05, 2013 at 05:40:34PM +0100, Jean-S?bastien P?dron wrote: > On 05.03.2013 16:37, Konstantin Belousov wrote: > > The patch below is supposed to fix double declaration (it is pathetic t= hat > > clang silently accepts this, while issuing countless useless warnings). > > Also there is a usual workaround for the anonimous union/struct issue. >=20 > What do you think about "-fms-extensions"? It avoids modifications to > the code and works with both gcc and clang. Since TTM code needs a lot of modifications anyway, I do not mind to make one more local change. I already did it, please see r247849. This is IMO better then getting more unhandled warnings. >=20 > There're several unnamed structs/unions in the radeon code too. I would > like to keep the diff with Linux code as small as possible. It is your call. I am only looking after the TTM right now. --oplxJGu+Ee5xywIT Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQIcBAEBAgAGBQJRNjZJAAoJEJDCuSvBvK1BAdkP/1oD5Sw0CIBghNCXOJ/JqLDk a77MCIw9ROQRKF5PyZ6/WBlH1D8Ihr1fkzsGQun8yHr+T0odem6sijEDf9lovLLw rjtec7wSpFwkxV3kCodqpAL4ArN+wJd2uDg8b8vW+MAYg4q0hgXWLUtAIhvsoXYx s6sCUqYfQiajDN4H2pP72Ga3/IrS6S1HmMMEzHYYVf1ScqiWE8bZ/xQiN2mCI6TI R4Lxmr+F8Bj4/opHXRwaLq/FunjaXM4HNLaAEipbR7eTegzNYxTrHnqWhykPggM/ jkDOG2b1ZWvERfc1gQzzGcpxbP8dlg7rajpE3jFEyb4WSb8cxn8vXSi+FOdPIksQ VYQlHaKJ3C3Ef7R2iRWzyuvOy5yYkmI8QCf8oU+bsoiYK97zgk26pmLeajfisUsI 2OHmJGw4cWc7ZuNnXYlidc5d373KFfEm6rTmJMzucEoDzLsjsvYTxitlvLKKXQWb GORb4t9rXkjahwgkA2xL1Ai5ioLNenv3CiwBw0/Lew8LiAXQ/It3omh7t/hqzpwQ Kb7A+Bi2T/1LYEvpjzVv9VoOAssDm2u9cH8iidJ9z2AR7UozFEsN1Ktza5B8XPir 9jfF+03eOb1vUMFwA/Ma9+DTlBu0WPVt3NyxzakblmtDhG60BKR9E7KT8BwemxIW 07v6IXa9bvHtC7cAODis =kiGj -----END PGP SIGNATURE----- --oplxJGu+Ee5xywIT--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130305181538.GJ3794>