Date: Thu, 31 Jan 2008 14:04:49 +0100 From: "Attilio Rao" <attilio@freebsd.org> To: "Yar Tikhiy" <yar@comp.chem.msu.su> Cc: Kostik Belousov <kostikbel@gmail.com>, Scot Hetzel <swhetzel@gmail.com>, freebsd-current@freebsd.org, Doug Barton <dougb@freebsd.org> Subject: Re: panic: System call lstat returning with 1 locks held Message-ID: <3bbf2fe10801310504j486924bdm86e0436597a42b09@mail.gmail.com> In-Reply-To: <20080131130210.GA37090@comp.chem.msu.su> References: <479BBDAA.6000008@FreeBSD.org> <479C0B5B.9030709@FreeBSD.org> <3bbf2fe10801270642m5ec609d8xb29add77ced36d8a@mail.gmail.com> <479FA3E8.10606@FreeBSD.org> <3bbf2fe10801291411v302dd33at54ebe538397e8fac@mail.gmail.com> <20080130130820.GA88429@comp.chem.msu.su> <3bbf2fe10801300707u3fd121c0k199605c2f0be6cbf@mail.gmail.com> <790a9fff0801301352xa91a69ci3f08488dfcfc982@mail.gmail.com> <3bbf2fe10801310243tddedfeckbc4c94be87f0a4ca@mail.gmail.com> <20080131130210.GA37090@comp.chem.msu.su>
next in thread | previous in thread | raw e-mail | index | archive | help
2008/1/31, Yar Tikhiy <yar@comp.chem.msu.su>:
> On Thu, Jan 31, 2008 at 11:43:10AM +0100, Attilio Rao wrote:
> >
> > The assertion failing should not happen now.
> > Could you please hand-add a check in _lockmgr_disown()
> > (kern/kern_lock.c) in order to check for the panicstr before to call
> > WITNESS? I cannot access to perforce now and produce a suitable diff,
> > so you can just do this by hand:
> >
> > if (lkp->lk_lockholder == td) {
> > if (panicstr != NULL)
> > WITNESS_UNLOCK(&lkp->lk_object, LOP_EXCLUSIVE, file, line);
> > td->td_locks--;
> > }
>
>
> Shouldn't the test for panicstr be inverse: `panicstr == NULL'?
> I guess we shouldn't call WITNESS when panicing, should we?
> Sorry if I got it wrong.
Weee, you are right, sorry!
Attilio
--
Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3bbf2fe10801310504j486924bdm86e0436597a42b09>