Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 11 Feb 2001 20:44:05 +0300
From:      "Andrey A. Chernov" <ache@nagual.pp.ru>
To:        Alexey Zelkin <phantom@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/lib/libc/locale lmessages.c
Message-ID:  <20010211204400.A94085@nagual.pp.ru>
In-Reply-To: <200102111509.f1BF9Vg00411@freefall.freebsd.org>; from phantom@FreeBSD.org on Sun, Feb 11, 2001 at 07:09:31AM -0800
References:  <200102111509.f1BF9Vg00411@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Feb 11, 2001 at 07:09:31 -0800, Alexey Zelkin wrote:
> phantom     2001/02/11 07:09:31 PST
> 
>   Modified files:
>     lib/libc/locale      lmessages.c 
>   Log:
>   Don't use hardcoded struct size, use offsetof() instead (make size calculations
>   dynamic)

The same as for lnumeric/lmonetary is true here too, i.e.

if (!ret)

should be changed to

if (!ret && _messages_using_locale) 

TWO TIMES

Currecntly no bad effect, just waste few CPU cycles.

BTW, YESSTR/NOSTR should be fixed in nl_langinfo() too...

-- 
Andrey A. Chernov
http://ache.pp.ru/


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010211204400.A94085>