Date: Sat, 3 Jul 1999 14:40:25 -0500 (CDT) From: Jim Bryant <jbryant@argus.tfs.net> To: ben@skunk.org (Ben Rosengart) Cc: freebsd-current@freebsd.org Subject: Re: Fixing other people's code (was: world broken in vinum (PATCH)) Message-ID: <199907031940.OAA26973@argus.tfs.net> In-Reply-To: <Pine.BSF.4.05.9907030008070.27759-100000@penelope.skunk.org> from Ben Rosengart at "Jul 3, 99 00:09:53 am"
next in thread | previous in thread | raw e-mail | index | archive | help
In reply: > On Sat, 3 Jul 1999, Greg Lehey wrote: > > > I personally think that, in such a case, you'd be justified to commit > > it as a temporary measure. Due to the difference in time zones, this > > has hit people while I've been asleep. That doesn't mean the commit > > would stay, of course, but at least it would save people unnecessary > > pain. Note, of course, that I have now committed the correct file, > > which I had forgotten last night. > > > > What do you others think? > > Was the fix that wasn't yours correct? 'Cause I'd rather have code that > doesn't compile than code that compiles but is subtly wrong. untested code shouldn't be checked in to begin with. such are the basics of version control. mistakes happen in any project, but where i come from CVS/RCS/etc is for tested and working code. if i made such a mistake, i would be grateful for a temporary kludge submitted by someone, assuming they know that it is subject to a proper fix at any moment. jim -- All opinions expressed are mine, if you | "I will not be pushed, stamped, think otherwise, then go jump into turbid | briefed, debriefed, indexed, or radioactive waters and yell WAHOO !!! | numbered!" - #1, "The Prisoner" ------------------------------------------------------------------------------ Inet: jbryant@tfs.net AX.25: kc5vdj@wv0t.#neks.ks.usa.noam grid: EM28pw voice: KC5VDJ - 6 & 2 Meters AM/FM/SSB, 70cm FM. http://www.tfs.net/~jbryant ------------------------------------------------------------------------------ HF/6M/2M: IC-706-MkII, 2M: HTX-212, 2M: HTX-202, 70cm: HTX-404, Packet: KPC-3+ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199907031940.OAA26973>