Date: Mon, 6 Sep 2010 15:36:38 +0200 (CEST) From: Lapo Luchini <lapo@lapo.it> To: FreeBSD-gnats-submit@FreeBSD.org Cc: Lapo Luchini <lapo@lapo.it>, ale@FreeBSD.org, miwi@FreeBSD.org Subject: ports/150327: [PATCH] www/xpi-adblock: do not install XPI metadata Message-ID: <201009061336.o86DacL4067412@lapo.andxor.it> Resent-Message-ID: <201009061340.o86De8bG072344@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 150327
>Category: ports
>Synopsis: [PATCH] www/xpi-adblock: do not install XPI metadata
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Mon Sep 06 13:40:07 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Lapo Luchini
>Release: FreeBSD 8.1-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD lapo.andxor.it 8.1-RELEASE FreeBSD 8.1-RELEASE #0: Mon Jul 19 02:36:49 UTC 2010
>Description:
Avoid installing an XPI's META-INF directory, as it contain meta-data and not actual data needed by the extension.
All of the XPIs I've seen having this directory use it to store digital signature data, which is checked on install (and thus has no need to be there for a system package); I don't know about any other data that is expected to fit in that directory, but by the very nature of it, it should all be meta-data relative to the XPI itself, not about the actual extension to be installed.
Some ports that are (IMvHO unnecessarily) installing that directory include:
www/xpi-adblock_plus
www/xpi-flashgot
www/xpi-joga
www/xpi-noscript
www/xpi-pdf_download
(all maintained by either ale@ or miwi@).
I propose to avoid installing that directory directly from Makefile.xpi, using the following patch or something similar.
Port maintainer (miwi@FreeBSD.org) is cc'd.
Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:
>Fix:
--- xpi-adblock-0.5.3.043.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/www/xpi-adblock/Makefile.xpi /usr/home/lapo/ports/xpi-adblock/Makefile.xpi
--- /usr/ports/www/xpi-adblock/Makefile.xpi 2009-12-14 15:39:12.000000000 +0100
+++ /usr/home/lapo/ports/xpi-adblock/Makefile.xpi 2010-09-06 15:19:01.000000000 +0200
@@ -188,6 +188,9 @@
${LN} -sf $$_xpi $$_app ${_Q} ; } ; }
.endif
+post-extract:
+ @${RM} -rf ${WRKSRC}/META-INF
+
# Maintainer section
xpi-gen: extract
@${ECHO_CMD} -n 'XPI_ID='
--- xpi-adblock-0.5.3.043.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201009061336.o86DacL4067412>