Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 15 Jun 2010 22:01:44 +0200
From:      Alexander Best <alexbestms@uni-muenster.de>
To:        Gabor Kovesdan <gabor@freebsd.org>
Cc:        freebsd-current@freebsd.org
Subject:   Re: [CFT] BSDL iconv in base system
Message-ID:  <AANLkTindxE6I6T2dj6nJNkzkszXH105-d07SsqDsDdXu@mail.gmail.com>
In-Reply-To: <AANLkTinSPmN046knazFOnN_Qy716UtzJgCHvzL3vlWOd@mail.gmail.com>
References:  <AANLkTim5bauRKyv2BM_0SkHDNZic-C6J20E0vuYPZRIq@mail.gmail.com> <4C17BB76.6020702@FreeBSD.org> <AANLkTinSPmN046knazFOnN_Qy716UtzJgCHvzL3vlWOd@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jun 15, 2010 at 7:56 PM, Alexander Best
<alexbestms@uni-muenster.de> wrote:
> On Tue, Jun 15, 2010 at 7:42 PM, Gabor Kovesdan <gabor@freebsd.org> wrote=
:
>>
>>> /usr/src/lib/libc/iconv/citrus_none.c: In function
>>> '_citrus_NONE_stdenc_cstomb':
>>> /usr/src/lib/libc/iconv/citrus_none.c:114: warning: unused variable 're=
t'
>>> *** Error code 1
>>>
>>
>> I'm sorry, this one slipped in. Today I've checked the sources with clan=
g
>> and fixed some minor warnings, including this one. The new patch is here=
:
>> http://www.kovesdan.org/patches/iconv_base_integrate2.diff
>>
>> And a gzipped version:
>> http://www.kovesdan.org/patches/iconv_base_integrate2.diff.gz
>
> thanks. i'll revert the previous patch and apply this new one.

with the new patch:

=3D=3D=3D> lib/libiconv_modules (all)
=3D=3D=3D> lib/libiconv_modules/BIG5 (all)
cc -fpic -DPIC -O2 -pipe -fno-strict-aliasing -funroll-loops
-march=3Dnative --param max-inline-insns-single=3D32
-I/usr/src/lib/libiconv_modules/BIG5/../../libc/iconv -g -std=3Dgnu99
-fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W
-Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes
-Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch
-Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline
-Wnested-externs -Wredundant-decls -Wold-style-definition
-Wno-pointer-sign -c /usr/src/lib/libiconv_modules/BIG5/citrus_big5.c
-o citrus_big5.So
cc1: warnings being treated as errors
/usr/src/lib/libiconv_modules/BIG5/../../libc/iconv/citrus_stdenc_template.=
h:
In function '_citrus_BIG5_stdenc_cstomb':
/usr/src/lib/libiconv_modules/BIG5/../../libc/iconv/citrus_stdenc_template.=
h:138:
warning: 'ret' may be used uninitialized in this function
*** Error code 1

Stop in /usr/src/lib/libiconv_modules/BIG5.
*** Error code 1

Stop in /usr/src/lib/libiconv_modules.
*** Error code 1

Stop in /usr/src/lib.
*** Error code 1

Stop in /usr/src.
*** Error code 1

Stop in /usr/src.
*** Error code 1

Stop in /usr/src.
*** Error code 1

Stop in /usr/src.


>
> cheers.
> alex
>
>>
>> --
>> Gabor Kovesdan
>> FreeBSD Volunteer
>>
>> EMAIL: gabor@FreeBSD.org .:|:. gabor@kovesdan.org
>> WEB: =A0 http://people.FreeBSD.org/~gabor .:|:. http://kovesdan.org
>>
>>
>
>
>
> --
> Alexander Best
>



--=20
Alexander Best



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTindxE6I6T2dj6nJNkzkszXH105-d07SsqDsDdXu>