Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 21 Oct 2001 18:07:09 +0100
From:      Brian Somers <brian@freebsd-services.com>
To:        Peter Wemm <peter@wemm.org>
Cc:        Brian Somers <brian@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@freebsd-services.com
Subject:   Re: cvs commit: src/sys/conf Makefile.i386 
Message-ID:  <200110211707.f9LH79b86891@hak.lan.Awfulhak.org>
In-Reply-To: Message from Peter Wemm <peter@wemm.org>  of "Sun, 21 Oct 2001 00:17:54 PDT." <20011021071754.CF876380A@overcee.netplex.com.au> 

next in thread | previous in thread | raw e-mail | index | archive | help
> Brian Somers wrote:
> > brian       2001/10/17 06:57:32 PDT
> > 
> >   Modified files:
> >     sys/conf             Makefile.i386 
> >   Log:
> >   Change kern.bootfile when mv'ing the kernel
> 
> This backs out part of rev 1.169, which was an intentional change..
> 
> This is incomplete..
> what if it is the second 'make install'?
> What if sysctl isn't in $PATH?
> What if it is an old sysctl that needs the -w switch?  There isn't
> an error trap to eat the error code, will this cause 'make installkernel'
> to fail? Hmm, it seems it does:
> 
> peter@overcee[12:15am]/home/src/sys/i386/compile/OVERCEE-111# make install      rm -rf /boot/kernel.old
> mv /boot/kernel /boot/kernel.old
> [ "`sysctl -n kern.bootfile`" != "/boot/kernel/kernel" ] ||  sysctl kern.bootfile=/boot/kernel.old/kernel
> sysctl: must use -w to modify variables
> *** Error code 1
> 
> Stop in /home/src/sys/i386/compile/OVERCEE.
> 
> Nothing is supposed to be using this sysctl, it's purely informational
> these days, and even then it has only part of the story.  The booted kernel
> may not even be reachable (eg: on an EFI filesystem or pulled in via tftp).

I guess it's wrong information...  Where is the name of the current 
kernel supposed to be gotten from ?  None of the documentation seems 
to point anywhere else.

Personally, I think my change was wrong.  The installkernel code should 
check to see if kern.bootfile is already kernel.old, and if it is, 
shouldn't move /boot/kernel/ on top of it.

WRT sysctl(8) not being in the path, are you suggesting that I spell 
it /sbin/sysctl ?  And WRT the command failing, are you suggesting 
that I simply put a ``-'' in front of the command ?

> Cheers,
> -Peter
> --
> Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au
> "All of this is for nothing if we don't go to the stars" - JMS/B5

Cheers.

-- 
Brian <brian@freebsd-services.com>                <brian@Awfulhak.org>
      http://www.freebsd-services.com/        <brian@[uk.]FreeBSD.org>
Don't _EVER_ lose your sense of humour !      <brian@[uk.]OpenBSD.org>



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200110211707.f9LH79b86891>