Date: Thu, 01 Jul 2010 15:22:12 +0800 From: Kevin Lo <kevlo@FreeBSD.org> To: Jack Vogel <jfvogel@gmail.com> Cc: svn-src-head@FreeBSD.org, Kevin Lo <kevlo@FreeBSD.org>, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r209622 - head/sys/dev/ixgbe Message-ID: <1277968932.2050.37.camel@nsl> In-Reply-To: <AANLkTimNiPk8fe_lvVbgCfgNSMuceW79bsxBqGI-PhDL@mail.gmail.com> References: <201007010503.o6153O78066276@svn.freebsd.org> <AANLkTimNiPk8fe_lvVbgCfgNSMuceW79bsxBqGI-PhDL@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Jack,
This is YOUR problem. First, you committed the code without testing,
glebius@ fixed it after 17 hours. Second, you didn't bring your
working copy into sync with the latest revision in the repository
and didn't notice build broken was fixed.
I just updated the source and recompiled kernel, found there's broken
on ixgbe(4). Since the fix is trivial, so I fixed it and wanted to
test something with the latest kernel.
Kevin
Jack Vogel wrote:
> I went to a LOT of trouble setting up a mirror at home and just as I
> went to commit
> the change its updated.
>
> While I understand the good intentions, please don't do this again. If
> I had been
> unresponsive for days or something I understand, but its been hours,
> and I was
> fixing it.
>
> Jack
>
>
> On Wed, Jun 30, 2010 at 10:03 PM, Kevin Lo <kevlo@freebsd.org> wrote:
> Author: kevlo
> Date: Thu Jul 1 05:03:24 2010
> New Revision: 209622
> URL: http://svn.freebsd.org/changeset/base/209622
>
> Log:
> Fix build
>
> Modified:
> head/sys/dev/ixgbe/ixgbe.h
>
> Modified: head/sys/dev/ixgbe/ixgbe.h
> ==============================================================================
> --- head/sys/dev/ixgbe/ixgbe.h Thu Jul 1 03:48:45 2010
> (r209621)
> +++ head/sys/dev/ixgbe/ixgbe.h Thu Jul 1 05:03:24 2010
> (r209622)
> @@ -382,7 +382,6 @@ struct adapter {
> u32 link_speed;
> bool link_up;
> u32 linkvec;
> - int advertise;
>
> /* Mbuf cluster size */
> u32 rx_mbuf_sz;
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1277968932.2050.37.camel>