Date: Mon, 18 Dec 2000 07:36:55 +0100 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: John Baldwin <jhb@FreeBSD.ORG> Cc: current@FreeBSD.ORG Subject: Re: test/review: /dev/console logging patch Message-ID: <25651.977121415@critter> In-Reply-To: Your message of "Sun, 17 Dec 2000 15:04:56 PST." <XFMail.001217150456.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <XFMail.001217150456.jhb@FreeBSD.org>, John Baldwin writes: > >On 17-Dec-00 Poul-Henning Kamp wrote: >> >> This patch is for the printf(9), log(9) & /dev/console stuff. >> The result is that you can watch the output from /etc/rc in >> your /var/log/messages. >> >> Poul-Henning >> >> >> 1. Replace logwakeup() with msgbuftrigger++; There is little >> point in calling a function to set a flag. > >Abstraction to keep other code from having to know the iternals of the log(9) >device? Maybe use a #define for logwakeup() that does the msgbuftrigger++ to >keep the abstraction w/o the overhead? But it was actually the other way around now :-) It was the log device which had obfuscated the log/printf code because it needed it's assistance to call selwakeup. I want the log/printf code to be as simple as possible, and to have the smallest stack footprint possible... -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?25651.977121415>