Date: Thu, 15 Feb 2001 01:59:01 +0300 From: =?koi8-r?B?4c7E0sXKIP7F0s7P1w==?= <ache@nagual.pp.ru> To: Alexey Zelkin <phantom@cris.crimea.ua> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/locale ldpart.c ldpart.h Message-ID: <20010215015901.A76630@nagual.pp.ru> In-Reply-To: <000e01c09686$8b6e0040$ce8f6ed4@spider.cris.net>; from phantom@cris.crimea.ua on Wed, Feb 14, 2001 at 04:02:53PM %2B0300 References: <000e01c09686$8b6e0040$ce8f6ed4@spider.cris.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Feb 14, 2001 at 16:02:53 +0300, Alexey Zelkin wrote: > It's not such simple as you propose. First of all, num_lines check should be > located > before code which fills internal structures (i.e. before set_from_buf() > call). Yes, you need to read whole file first then parse it to struct according to calculated num_lines, then free temp buf. > IMHO, both variants are just overheads and includes a lot of unneeded code > to libc. I think we don't There is no overheads in that, just separation. > need such changes until we really need them. BTW, I don't propose to add > __part_load_locale() > calls to libc anymore because it's already used in all places there I > proposed to use it. Also __part_load_locale() is libc internal function and > will not be used in any external programs. > Logicaly next step is optimization and not universalization, isn't it ? Currently yes, but in my memory LC_TIME locale grows several times, so planned again too. At this moment I am unhappy with our %Ef solution because it is non-standard. I am unhappy with our %c solution too. I think it should be rewritted somehow when standard bodies got acceptable workarounds. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010215015901.A76630>