Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 24 Oct 2007 12:50:09 GMT
From:      Pietro Cerutti <gahr@gahr.ch>
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   Re: ports/117319: [patch] games/xlogical bad C++ code w/ gcc4.2
Message-ID:  <200710241250.l9OCo9lF045482@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/117319; it has been noted by GNATS.

From: Pietro Cerutti <gahr@gahr.ch>
To: Sergio Mangialardi <sergio@softshark.org>,  bug-followup@FreeBSD.org, 
 gahr@gahr.ch
Cc:  
Subject: Re: ports/117319: [patch] games/xlogical bad C++ code w/ gcc4.2
Date: Wed, 24 Oct 2007 14:42:35 +0200

 Sergio Mangialardi wrote:
 > Pietro Cerutti wrote:
 >>
 >> You are right. Please comment on this one:
 >>
 >> --- gamelogic.cpp.orig  2007-10-19 17:52:30.000000000 +0200
 >> +++ gamelogic.cpp       2007-10-19 17:53:15.000000000 +0200
 >> @@ -154,7 +154,7 @@
 >>                 levelFile = NULL;
 >>         }
 >>
 >> -       currentMap = NULL;
 >> +       currentMap = gameLevels.end( );
 > This is the correct initialization of currentMap, because it is
 > independent of the underlying implementation of the iterator.
 > 
 > Sergio.
 
 Thanks.
 
 I think the patch is ready to be committed.
 
 -- 
 Pietro Cerutti
 
 PGP Public Key:
 http://gahr.ch/pgp



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200710241250.l9OCo9lF045482>