Date: Tue, 8 Jan 2013 08:53:35 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Glen Barber <gjb@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r310063 - in head: . sysutils/cfengine Message-ID: <20130108075335.GQ85686@ithaqua.etoilebsd.net> In-Reply-To: <20130108071049.GP85686@ithaqua.etoilebsd.net> References: <201301080433.r084X9IR015052@svn.freebsd.org> <20130108071049.GP85686@ithaqua.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--Tcb1KvpfnM4LxW2s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 08, 2013 at 08:10:49AM +0100, Baptiste Daroussin wrote: > On Tue, Jan 08, 2013 at 04:33:09AM +0000, Glen Barber wrote: > > Author: gjb > > Date: Tue Jan 8 04:33:08 2013 > > New Revision: 310063 > > URL: http://svnweb.freebsd.org/changeset/ports/310063 > >=20 > > Log: > > Implement the concept of a "master" port for the set of > > sysutils/cfengine* ports. > > =20 > > The idea here is two-fold: > > =20 > > 1.) Users should not need to ever change port origins > > for a default software version bump; > > 2.) Users should expect to exist an unversioned port > > directory to reflect the latest major version (and > > they should be correct in this expectation). > > =20 > > With this change, users can install the sysutils/cfengine > > port, and by default track the latest major version of the > > software. Subsequent version releases, for example the 3.5 > > branch, will not require any interaction from user side. > > =20 > > Additionally, users can stay on a certain branch release by > > adding, in this case, CFENGINE_VERSION version to make.conf > > or specifying the branch during build time with: > > =20 > > # make CFENGINE_VERSION=3DNN > > =20 > > The list of available CFENGINE_VERSION values are listed > > with: > > =20 > > # make -V VERSIONS > > =20 > > Discussed with: cy > >=20 >=20 > Nice! In my opinion this should be followed by all/most? ports with multi > version in the ports tree, this will fix also fix tracking in binary work= major > upgrades (aka change of default version) with no manuall intervention. >=20 > regards, > Bapt While I do like this idea, the implementation is broken: index and package building is broken now let me show you why: # cd /usr/ports/sysutils/cfengine # make -VPKGNAME -VLATEST_LINK cfengine-3.4.1 cfengine34 # cd /usr/ports/sysutils/cfengine34 # make -VPKGNAME -VLATEST_LINK cfengine-3.4.1 cfengine34 and it is forbidden to have 2 exactly same LATEST_LINK and 2 exactly same PKGNAME imho the right thing would be in cfengine34 to: define LATEST_LINK only if !defined(MASTERDIR) and to add PKGNAMESUFFIX=3D34 if !defined(MASTERDIR) regards, Bapt --Tcb1KvpfnM4LxW2s Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlDr0H8ACgkQ8kTtMUmk6Ew3tgCfbj6uoIxXf77FgE+UFBeAMUHh o10AoL4SMeImnOUHMjsj6EOA5b4EWe2E =vRSH -----END PGP SIGNATURE----- --Tcb1KvpfnM4LxW2s--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130108075335.GQ85686>