Date: Fri, 02 Jul 2010 09:48:38 +0300 From: Alexander Motin <mav@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r209638 - in head/sys: amd64/amd64 i386/i386 Message-ID: <4C2D8BC6.8000603@FreeBSD.org> In-Reply-To: <201007011822.02280.jhb@freebsd.org> References: <201007012158.o61LwkJW096565@svn.freebsd.org> <201007011822.02280.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote: > On Thursday 01 July 2010 05:58:46 pm Alexander Motin wrote: >> Author: mav >> Date: Thu Jul 1 21:58:46 2010 >> New Revision: 209638 >> URL: http://svn.freebsd.org/changeset/base/209638 >> >> Log: >> Make stray irq counters have format alike to other counters. Unified >> format makes string processing (for example by `systat -vm`) easier. > > As I said on the mailing lists, I actually think that the old way is a > feature. I believe bde@ also has useful input on appropriately parsing > interrupt names for systat -vmstat output. Yes, we had a long conversation with Bruce. Stray interrupts on x86 were the only case found, where some other text, unrelated to event source name, printed before "irqX". I would prefer not to have such special cases instead of trying to handle them all. With more people objecting now, despite my arguments, I'll have to obey. But I still don't think that attempts to parse unformatted string is a good idea. -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C2D8BC6.8000603>