Date: Tue, 10 Apr 2007 13:13:10 -0700 From: Nate Lawson <nate@root.org> To: Giorgos Keramidas <keramida@freebsd.org> Cc: S?ren Schmidt <sos@deepcore.dk>, Ariff Abdullah <ariff@freebsd.org>, current@freebsd.org Subject: Re: recent commits break via 8235 ata Message-ID: <461BEFD6.2050302@root.org> In-Reply-To: <20070406211229.GB1078@kobe.laptop> References: <4608A5D9.2010902@root.org> <20070327151058.5qk9etifk880g4cc@webmail.leidinger.net> <20070327140741.GA60454@kobe.laptop> <200703271227.14308.jhb@freebsd.org> <20070406211229.GB1078@kobe.laptop>
next in thread | previous in thread | raw e-mail | index | archive | help
Giorgos Keramidas wrote: > On 2007-03-27 12:27, John Baldwin <jhb@freebsd.org> wrote: >> If that is the case it's because code was using >> rman_get_bus(handle|tag) on a resource that wasn't activated yet which >> wouldn't have worked before the nexus changes either. Well, the bus >> tag might have been right, but the handle for SYS_RES_MEMORY would >> have been wrong. > > This is the change which stops snd_hda from working here: > > % Date: Wed, 21 Mar 2007 15:39:12 +0000 (UTC) > % Message-Id: <200703211539.l2LFdCQW036704@repoman.freebsd.org> > % From: John Baldwin <jhb@freebsd.org> > % Subject: cvs commit: src/sys/dev/acpica acpi.c > % To: src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org > % Cc: > % > % jhb 2007-03-21 15:39:12 UTC > % > % FreeBSD src repository > % > % Modified files: > % sys/dev/acpica acpi.c > % Log: > % Change acpi's handling of suballocating system resources to be a little > % simpler. It now can just use rman_is_region_manager() during > % acpi_release_resource() to see if the the resource is suballocated from > % a system resource. Also, the driver no longer needs MD knowledge about > % how to setup bus space tags and handles when doing a suballocation, but > % can simply rely on bus_activate_resource() in the parent setting all that > % up. > % > % Revision Changes Path > % 1.233 +39 -55 src/sys/dev/acpica/acpi.c > > If I update my kernel sources to Wed Mar 21 14:39:39 2007 +0000 > (including the sys/modules/padlock/Makefile commit of Sam Leffler, to > fix the kernel build from Wed Mar 21 17:37:13 2007 +0000), I can see > that the snd_hda driver probes my sound card correctly. > > Updating after the commit shown above, breaks snd_hda. I just finished a binsearch and can verify this exact commit causes the problem for my ATA also. I'll spend some more time debugging it later. John, can I back out rev 1.233 of acpi.c until you return since it prevents some machines from booting? -- Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?461BEFD6.2050302>