Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 2 Mar 2006 21:52:55 -0500
From:      Craig Rodrigues <rodrigc@crodrigues.org>
To:        Giorgos Keramidas <keramida@FreeBSD.org>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sbin/mount mount.c
Message-ID:  <20060303025255.GA6845@crodrigues.org>
In-Reply-To: <200603030246.k232kFuh095400@repoman.freebsd.org>
References:  <200603030246.k232kFuh095400@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Mar 03, 2006 at 02:46:15AM +0000, Giorgos Keramidas wrote:
> keramida    2006-03-03 02:46:15 UTC
> 
>   FreeBSD src repository (doc committer)
> 
>   Modified files:
>     sbin/mount           mount.c 
>   Log:
>   When there are no mount options, an implicit "rw" should be printed in
>   the output of ``mount -p''.
>   
>   Approved by:    rodrigc

Just as additional background, the putfsent() in mount.c which
displays an fstab via mount -p is lacking in one serious way...
it only converts the numeric mount flags to strings.

It is possible to specify mount options in /etc/fstab,
or via mount -o which are strings that are passed down into
the kernel via nmount().  These strings *may* or *may not* be
converted to numerical mount flags, and maybe be stored
in the kernel as strings, depending on the filesystem.

This makes filesystem mount option parsing such a pain.

-- 
Craig Rodrigues        
rodrigc@crodrigues.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060303025255.GA6845>