Date: Thu, 22 Dec 2011 15:10:11 GMT From: Rainer Hurling <rhurlin@gwdg.de> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/163367: [maintainer] [patch] sysutils/wmupmon: build error and missing URL Message-ID: <201112221510.pBMFABtd053498@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/163367; it has been noted by GNATS. From: Rainer Hurling <rhurlin@gwdg.de> To: Michael Scheidell <scheidell@freebsd.org> Cc: bug-followup@FreeBSD.org Subject: Re: ports/163367: [maintainer] [patch] sysutils/wmupmon: build error and missing URL Date: Thu, 22 Dec 2011 16:04:05 +0100 On 22.12.2011 14:20 (UTC+1), Michael Scheidell wrote: > A warning is usually just a warning, you will see many of these when you > build FreeBSD source. Yes, I am aware of this. Erroneously I misspelled the build warning as build error, sorry for that. > If the patch corrects something in the upstream, maybe you could submit > it to them so they can properly QA it? Hmm, I am afraid, there is no upstream support for years now :-( > If you are willing to approve this update without the patches, I think > they can be committed pretty quickly, but these patches would need some > time to doublecheck it doesn't open a security/buffer/stack problem. It is only src/update_freebsd.c which I changed because of the warning. The patchfile for src/main.c was only renamed from patch-src_main.c to patch-src__main.c (double underscore). I personally can live without the patch of src/update_freebsd.c, so I would be pleased if you would commit it. Thanks for taking this PR up, Rainer
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201112221510.pBMFABtd053498>