Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 11 Jan 1998 03:42:29 +0000
From:      Brian Somers <brian@awfulhak.org>
To:        freebsd-hackers@FreeBSD.ORG
Subject:   Change to config(8)
Message-ID:  <199801110342.DAA20820@awfulhak.demon.co.uk>

next in thread | raw e-mail | index | archive | help
Hi,

I'd like to commit this change, but I don't know if it's correct.

AFAICT, because the minor() bit of a dev_t is only 8 bits, minors of >
256 are useless.  They also break the -current DEVFS code in that you 
end up with an increased major number (oops!) if you (for example)

  pseudo-device tun 257

However, I haven't committed it because I don't know where things 
like /dev/sd0s1 get their minors (0x00020002).

-- 
Brian <brian@Awfulhak.org>, <brian@FreeBSD.org>, <brian@OpenBSD.org>
      <http://www.Awfulhak.org>;
Don't _EVER_ lose your sense of humour....

Index: mkheaders.c
===================================================================
RCS file: /home/ncvs/src/usr.sbin/config/mkheaders.c,v
retrieving revision 1.8
diff -c -r1.8 mkheaders.c
*** mkheaders.c	1997/11/07 00:09:40	1.8
--- mkheaders.c	1998/01/11 03:40:28
***************
*** 129,134 ****
--- 129,136 ----
  	FILE *inf, *outf;
  	int inc, oldcount;
  
+ 	if (count > 256)
+ 		count = 256;
  	file = toheader(hname);
  	name = tomacro(dev);
  	inf = fopen(file, "r");





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199801110342.DAA20820>