Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 1 Jun 2009 08:15:49 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        Kip Macy <kmacy@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-user@freebsd.org
Subject:   Re: svn commit: r193078 - in user/kmacy/releng_7_2_fcs/sys: amd64/amd64 vm
Message-ID:  <200906010815.49692.jhb@freebsd.org>
In-Reply-To: <200905300105.n4U15VAF092086@svn.freebsd.org>
References:  <200905300105.n4U15VAF092086@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 29 May 2009 9:05:31 pm Kip Macy wrote:
> -	--m->wire_count;
> +	atomic_subtract_int(&m->wire_count, 1);
>  	if (m->wire_count == 0)
>  		return _pmap_unwire_pte_hold(pmap, va, m, free);

This is not safe.  Use atomic_fetchadd() instead to do this atomically the way 
refcount_* do.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200906010815.49692.jhb>