Date: Tue, 23 Jul 2013 09:11:30 +0200 From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= <uqs@FreeBSD.org> To: scsi@freebsd.org Cc: gibbs@FreeBSD.org, ken@freebsd.org Subject: Re: Please review patch for aic7xxx_pci.c Message-ID: <20130723071129.GD9030@acme.spoerlein.net> In-Reply-To: <20130716094927.GA9030@acme.spoerlein.net> References: <20130716094927.GA9030@acme.spoerlein.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[adding scsi, it would be nice if I could get another set of eyes on this as I don't have the hardware to test this] On Tue, 2013-07-16 at 11:49:27 +0200, Ulrich Spörlein wrote: > > Hey Justin, Ken, > > Coverity found one more instance of swapped parameters in the kernel, > introduced quite some time ago. It's probably hard to get the hardware > to test this change these days ... > > Please see > https://github.com/uqs/freebsd-head/commit/2f8f438a380c2a52a2e9f266cd716f56c8a4bb75 > and leave comments, or reply to this mail. > > You can see the diff that introduced the problem here: > http://git.freebsd.your.org/gitweb/?p=freebsd.git;a=blobdiff;f=sys/dev/aic7xxx/aic7xxx_pci.c;h=42dcdcc57f09d11199aabd6b224f2dad730f0733;hp=a4c0f4672cab3eb965d7acf1a580162168ca9716;hb=27ca4db2579f6e74861db16299eeb52e158fa7a7;hpb=06842004edacee7beec6cb72239ded59709506a2 > > or here: > > https://github.com/uqs/freebsd-head/commit/9696016b0572574bb656fb109ff2916127fa8cb8 > > Thanks! > Uli
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130723071129.GD9030>