Date: Sun, 13 Mar 2016 11:28:51 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 207782] New port: audio/dsbmixer: Tabbed GTK+ mixer Message-ID: <bug-207782-13-OuWuHEM01j@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-207782-13@https.bugs.freebsd.org/bugzilla/> References: <bug-207782-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D207782 Raphael Kubo da Costa <rakuco@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rakuco@FreeBSD.org --- Comment #4 from Raphael Kubo da Costa <rakuco@FreeBSD.org> --- Hi, A few suggestions you can follow to simplify the Makefile: - There's an NLS description in Mk/bsd.options.desc.mk that can be used so = you don't need to set NLS_DESC. - Instead of including bsd.port.options.mk and checking for the options, you can use the syntax helpers: NLS_MAKE_ARGS_OFF=3D -DWITHOUT_GETTEXT # you can unconditionally set NLS_LANGS DEVD_MAKE_ARGS_OFF=3D -DWITHOUT_DEVD - dsbmixer's Makefile already has an install target, so you shouldn't need = to define do-install yourself. Since you are also dsbmixer's upstream author, I suggest you just improve its Makefile to support the DESTDIR variable: this would allow `make stage' to work without any changes and everything would w= ork out of the box. - Speaking of upstream, something you should consider is to ship a separate COPYING or LICENSE file with the license the code is licensed under. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-207782-13-OuWuHEM01j>