Date: 5 Sep 2006 20:09:51 -0000 From: Coleman Kane <cokane@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/102919: PATCH: net/samba3 and derivatives use wrong gssapi.h header Message-ID: <20060905200951.68972.qmail@ramen.cokane.org> Resent-Message-ID: <200609052010.k85KAMGV094943@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 102919 >Category: ports >Synopsis: PATCH: net/samba3 and derivatives use wrong gssapi.h header >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Sep 05 20:10:22 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Coleman Kane >Release: FreeBSD 7.0-CURRENT amd64 >Organization: FreeBSD Committers >Environment: System: FreeBSD erwin 7.0-CURRENT FreeBSD 7.0-CURRENT #1: Tue Aug 29 17:10:06 EDT 2006 root@erwin:/usr/obj/usr/src/sys/ERWIN amd64 >Description: I have noticed that the net/samba3, net/samba-libsmbclient and probably other samba3-derived ports complain about #include <gssapi.h> being deprecated in favor of #include <gssapi/gssapi.h>. Since we have the #warning header installed, the auto-search for the "appropriate" gssapi.h (gssapi/gssapi.h) fails to find the correct one, because of the search order. The attached patch reverses part of the search order, so that the correct <gssapi/gssapi.h> header takes prescedence over the stub <gssapi.h>. >How-To-Repeat: Build net/samba3 or net/samba-libsmbclient from ports. >Fix: Attached patch should be put into /usr/ports/net/samba3/files/patch-includes.h: --- include/includes.h.orig Wed Aug 23 12:16:38 2006 +++ include/includes.h Tue Sep 5 15:34:20 2006 @@ -475,10 +475,10 @@ #undef HAVE_LDAP #endif -#if HAVE_GSSAPI_H -#include <gssapi.h> -#elif HAVE_GSSAPI_GSSAPI_H +#if HAVE_GSSAPI_GSSAPI_H #include <gssapi/gssapi.h> +#elif HAVE_GSSAPI_H +#include <gssapi.h> #elif HAVE_GSSAPI_GSSAPI_GENERIC_H #include <gssapi/gssapi_generic.h> #endif >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060905200951.68972.qmail>