Date: Thu, 19 Dec 2002 09:17:56 +0100 From: Johan Karlsson <johan@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/realpath realpath.c Message-ID: <20021219081755.GA35556@numeri.campus.luth.se> In-Reply-To: <20021219115633.J28208-100000@gamplex.bde.org> References: <200212181020.gBIAKeJw081000@repoman.freebsd.org> <20021219115633.J28208-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Dec 19, 2002 at 12:01 (+1100) +0000, Bruce Evans wrote:
> On Wed, 18 Dec 2002, Johan Karlsson wrote:
>
> > johan 2002/12/18 02:20:40 PST
> >
> > Modified files:
> > bin/realpath realpath.c
> > Log:
> > - use MAXPATHLEN per realpath(3)
>
> This is sort of backwards. realpath(3) is standard in POSIX.1.2001 and
> spells the limit {PATH_MAX}. MAXPATHLEN has the advantage of being
> explictly unportable, but we (mainly imp) usually replace MAXPATHLEN
> by PATH_MAX. (The compile-time constant PATH_MAX should not be confused
> with the POSIX limit {PATH_MAX} or used if it is not defined, but
> MAXPATHLEN is always defined on BSD systems.)
My commit made the code consistent with the manpage for realpath(3) which
says to use MAXPATHLEN. If that is wrong then we should change
the manpage to say PATH_MAX.
Should I revert this and change the manpage?
/Johan K
--
Johan Karlsson mailto:johan@FreeBSD.org
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021219081755.GA35556>