Date: Wed, 13 Oct 2010 22:17:10 +0100 From: Rui Paulo <rpaulo@freebsd.org> To: Jung-uk Kim <jkim@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r213779 - head/sys/dev/sound/pci Message-ID: <C8F8A6C0-CBFB-4874-9D71-F311D64EA0B3@freebsd.org> In-Reply-To: <201010131703.21145.jkim@FreeBSD.org> References: <201010131439.o9DEdssc090571@svn.freebsd.org> <201010131546.10130.jkim@FreeBSD.org> <F670176F-BA62-44ED-9CC5-06C36A191258@freebsd.org> <201010131703.21145.jkim@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 13 Oct 2010, at 22:03, Jung-uk Kim wrote: > On Wednesday 13 October 2010 04:30 pm, you wrote: >> I read the PR and the mailing list posts, but I don't see what >> problem does "case SPICDS_TYPE_AK4381 || SPICDS_TYPE_AK4396:" fix. >=20 > A similar bug for right channel was fixed by netchild@ in r188480: >=20 > = http://svn.freebsd.org/viewvc/base/head/sys/dev/sound/pci/spicds.c?view=3D= log >=20 > but he missed the left channel, which caused volume differences=20 > between the two channels. >=20 > "In FreeBSD 7.2 it worked just like a charm but after upgrading to 8.0 > the left stereo channel is only half as loud as the right one. It can=20= > be reproduced with either speakers and headphones. I tracked it down=20= > to a change in revision 188480 of spicds.c, the change "fix: stupid=20 > bug with volume control for AK4396" breaks volume control for me. >=20 > = http://lists.freebsd.org/pipermail/freebsd-multimedia/2009-December/010553= html >=20 > Carl Johan Gustavsson submitted a correct patch: >=20 > = http://lists.freebsd.org/pipermail/freebsd-multimedia/2009-December/010558= html >=20 > ariff@ said he would take it but I guess he never did: >=20 > = http://lists.freebsd.org/pipermail/freebsd-multimedia/2009-December/010575= html Oh, I read your previous email backwards. This explains it, thanks. = Guess we can close the PR now. Regards, -- Rui Paulo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C8F8A6C0-CBFB-4874-9D71-F311D64EA0B3>